[Entitlements] Cross-platform implementation of Path.isAbsolute() #123282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
auto-backport
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Feb 24, 2025
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
Looks good, but can you switch the use of isAbsolute in parsing to this?
Contributor
Author
I was planning to do that in a separate PR but sure, I can do it now |
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 24, 2025
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 24, 2025
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 25, 2025
…23282) (#123317) Co-authored-by: Lorenzo Dematté <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 25, 2025
…23282) (#123318) Co-authored-by: Lorenzo Dematté <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 25, 2025
…23282) (#123319) Co-authored-by: Lorenzo Dematté <[email protected]>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our own utility to determine if a path is absolute or relative.
Note that this leads to a conflict, resolved in favor of Unix rules:
/foocan be either a Unix absolute path, or a Windows relative path with "wrong" directory separator (using non-canonical slash in Windows).The code is "copied" (and simplified) from the JDK implementations of
UnixPath#isAbsoluteandWindowsPathParser#parseRelates to ES-10912